Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

def: macros for creating copattern definitions #376

Merged
merged 10 commits into from
Jun 21, 2024
Merged

Conversation

TOTBWF
Copy link
Collaborator

@TOTBWF TOTBWF commented Apr 14, 2024

Description

There are a couple of places in the 1Lab where we manually eta-expand out copattern definitions by hand to get better goal display. This mostly comes up when dealing with things like subcategories/forgetful functors; Agda will very happily unfold your nicely named category into Restrict Blah, which is not particularly helpful!

Manually performing these copattern expansions is a bit of a pain, so this PR adds a small macro that performs this mechanical busywork for us. This removes the need for the declare-concrete-category macro in #375.

Checklist

Before submitting a merge request, please check the items below:

  • I've read the contributing guidelines.
  • The imports of new modules have been sorted with support/sort-imports.hs (or nix run --experimental-features nix-command -f . sort-imports).
  • All new code blocks have "agda" as their language.

If your change affects many files without adding substantial content, and
you don't want your name to appear on those pages (for example, treewide
refactorings or reformattings), start the commit message and PR title with chore:.

@TOTBWF TOTBWF requested review from ncfavier and plt-amy April 14, 2024 16:18
@ncfavier
Copy link
Member

Can this be unified with Cat.Functor.Coherence?

@Lavenza
Copy link
Member

Lavenza commented Apr 14, 2024

Pull request preview

@TOTBWF
Copy link
Collaborator Author

TOTBWF commented Apr 14, 2024

Can this be unified with Cat.Functor.Coherence?

Should be able to! We will need to generalize make-copattern to work on functions into record types, but this shouldn't be too hard.

@TOTBWF
Copy link
Collaborator Author

TOTBWF commented Apr 15, 2024

Should be good to go. Played around with a version of "deep" cohere! that would let us solve things like https://1lab.dev/Cat.Functor.Adjoint.html#25843 but this proved to be a bit tricky

@plt-amy
Copy link
Member

plt-amy commented May 21, 2024

Looks good, are there places we can use it? (Sheaves, I guess? But I'm not done writing that yet :/)

@TOTBWF
Copy link
Collaborator Author

TOTBWF commented Jun 12, 2024

Sorry, have been quite busy recently! Sheaves would be a good place, likewise for categories of free F-algebras

@plt-amy plt-amy merged commit 133d244 into main Jun 21, 2024
5 checks passed
@plt-amy plt-amy deleted the copattern-macro branch June 21, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants