Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dont import module in setup anymore #16

Merged
merged 1 commit into from
Jun 28, 2018
Merged

Dont import module in setup anymore #16

merged 1 commit into from
Jun 28, 2018

Conversation

pltrdy
Copy link
Owner

@pltrdy pltrdy commented Jun 28, 2018

@pltrdy pltrdy merged commit 8255cac into master Jun 28, 2018
@AlJohri
Copy link

AlJohri commented Jun 28, 2018

@pltrdy here's one approach I use for the version btw: https://github.com/AlJohri/craigslist/blob/master/setup.py#L6

@AlJohri
Copy link

AlJohri commented Jun 28, 2018

another more involved example: https://github.com/kennethreitz/setup.py/blob/master/setup.py#L40-L46

@pltrdy
Copy link
Owner Author

pltrdy commented Jun 28, 2018

Thanks for pointing this out. I'm aware of those, but honestly, I think that it does not makes it super clear/simple. Duplicating isn't a good practice in general, but I think that it's really ok in this case.

@pltrdy pltrdy deleted the fix_setup branch January 9, 2019 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

missing dependency, six?
2 participants