Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implements a flag to allow ignoring of empty hypotheses #18

Merged
merged 3 commits into from
Sep 19, 2018

Conversation

veskoch
Copy link
Contributor

@veskoch veskoch commented Sep 13, 2018

Empty hypotheses passed for evaluation (common during early stages of training and evaluation) will raise an Assertion Error unless the ignore_empty argument of the get_scores method of the Rouge class is set to True.

veskoch and others added 3 commits September 13, 2018 18:02
Empty strings passed for evaluation (common during early stages of training and evaluation) raise an Assertion Error unless the `ignore_empty` argument of the `get_scores` method of the `Rouge` class is set to True.
@pltrdy
Copy link
Owner

pltrdy commented Sep 19, 2018

Thanks for this PR.
I slightly modified it to make the feature available from command line (using a new --ignore_empty flag).

Note that this behavior should be avoided by default.


@pltrdy pltrdy merged commit 1048ef3 into pltrdy:master Sep 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants