Update live tests #153
Merged
Update live tests #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* The old blob test was fetching a commit, so changed that to a blob. * Dates are now returned in Z timezone, changed that * Message is now chomp'ed * added html_url to the two places the API now returns it.
* Dateformat changed to Z timezone * donwload urls point to API now
* changed from 204 -> 200 * udpated expected result
|
Thanks a lot for all these fixes. In the past I had a 2nd account here on Github to run these tests. So I would not pollute the activity stream of my followers :). I'm going to merge this right now and would be really happy if you could upload a new release to the CPAN. Thanks for your great work 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran the live tests (not the ones needing a
token, as they looked more "dangerous").Updated the following things, if this looks ok to you @plu, I'll do a dzil release later today :)