Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wishlisted methods to Pithub::Repos. #201

Merged
merged 2 commits into from
Feb 16, 2018
Merged

Add wishlisted methods to Pithub::Repos. #201

merged 2 commits into from
Feb 16, 2018

Conversation

jjatria
Copy link
Contributor

@jjatria jjatria commented Feb 13, 2018

This patch adds two methods to Pithub::Repos: ->issues and ->pull_requests. These act as shortcuts to access a Pithub::Issues and Pithub::PullRequests inheriting the parameters from the parent repo.

This makes it easier to use Pithub in the way requested in #194 and #196.

This PR brought to you by the CPAN pull request challenge.

@coveralls
Copy link

coveralls commented Feb 13, 2018

Coverage Status

Coverage increased (+0.003%) to 99.075% when pulling 7a01e14 on jjatria:wishlist into 6ec66c3 on plu:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.004%) to 99.017% when pulling da68228 on jjatria:wishlist into ad4c3ba on plu:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.004%) to 99.017% when pulling da68228 on jjatria:wishlist into ad4c3ba on plu:master.

@oalders
Copy link
Collaborator

oalders commented Feb 15, 2018

I think if you rebase using the latest changes from master we should get a fully passing build on this branch.

@oalders
Copy link
Collaborator

oalders commented Feb 15, 2018

LGTM. @plu?

@plu
Copy link
Owner

plu commented Feb 16, 2018

Looks great! Thanks for adding tests 👍

@plu plu merged commit 877aafd into plu:master Feb 16, 2018
@jjatria jjatria deleted the wishlist branch February 16, 2018 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants