Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: relations export #70

Closed
wants to merge 3 commits into from
Closed

fix: relations export #70

wants to merge 3 commits into from

Conversation

salmanm
Copy link

@salmanm salmanm commented Sep 12, 2022

What does it do?

Describe the technical changes you did.

Why is it needed?

Describe the issue you are solving.

How to test it?

Provide information about the environment and the path to verify the behaviour.

Related issue(s)/PR(s)

Let us know if this is related to any issue/pull request

@boazpoolman
Copy link
Member

Hi @salmanm,

The PR is still marked as Draft. Is that correct? Or is it ready for review?
Also the integration tests are failing. Are you seeing this?

@salmanm
Copy link
Author

salmanm commented Sep 19, 2022

@boazpoolman Yes I kept the PR draft as I'm not sure if the approach is a good fit for all cases.
Since I'm not super familiar with the codebase, I refrained from spending too much time without knowing if it's in the right direction.
I just opened it for discussion and ideas. I'd appreciate if you could do a sanity check to see if its not gonna break cases other than oneToMany. If you think it's in the right direction, I'd be happy to add/fix tests.

@salmanm salmanm closed this Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants