fix(targetticket,targetchange): bad return value in setTargetEntity

btry · btry · commit eff7ade42b17 · 2021-03-18T13:39:17.000+01:00
Signed-off-by: Thierry Bugier &lt;tbugier@teclib.com&gt;
diff --git a/inc/abstracttarget.class.php b/inc/abstracttarget.class.php
@@ -336,7 +336,7 @@ protected function setTargetEntity($data, PluginFormcreatorFormAnswer $formanswe
             }
             if (count($data_entities) < 1) {
                // No entity found
-               return $entityId;
+               break;
             }
             $first_entity = array_shift($data_entities);
             $entityId = $first_entity[$entityFk];

Original file line number	Diff line number	Diff line change
`@@ -336,7 +336,7 @@ protected function setTargetEntity($data, PluginFormcreatorFormAnswer $formanswe`
`336`	`336`	`}`
`337`	`337`	`if (count($data_entities) < 1) {`
`338`	`338`	`// No entity found`
`339`		`- return $entityId;`
	`339`	`+ break;`
`340`	`340`	`}`
`341`	`341`	`$first_entity = array_shift($data_entities);`
`342`	`342`	`$entityId = $first_entity[$entityFk];`