Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify Self-Host Deployment #12

Merged
merged 1 commit into from
Apr 28, 2024
Merged

Simplify Self-Host Deployment #12

merged 1 commit into from
Apr 28, 2024

Conversation

ItsRaelx
Copy link
Contributor

@ItsRaelx ItsRaelx commented Apr 27, 2024

closes #11
closes #10

As in feature request:

To improve the user experience, I propose that we consolidate our self-host deployment configuration into a single docker-compose.yml file. This approach would offer several benefits:

  • Easier deployment for users, as they would only need to manage one file
  • Elimination of duplicated environment variables, which could be moved from example.env to docker-compose.yml
  • Resolution of the Windows-specific issue reported in Self hosting error? #10
  • Automated folder creation by docker-compose, reducing the manual effort required from users

Also i don't think storing docker-compose.yml inside repository (that pulls from docker hub instead of building from source) is a good idea.

@pluja
Copy link
Owner

pluja commented Apr 28, 2024

looks good, I think it's fine to simplify

@pluja pluja merged commit 154c301 into pluja:main Apr 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Simplify Self-Host Deployment Self hosting error?
2 participants