Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make neighbor lists compatible with replica exchange #31

Closed
GiovanniBussi opened this issue Aug 28, 2013 · 3 comments
Closed

Make neighbor lists compatible with replica exchange #31

GiovanniBussi opened this issue Aug 28, 2013 · 3 comments

Comments

@GiovanniBussi
Copy link
Member

Currently all variables involving neighbor lists are not working properly with replica exchange. They should all crash the code, and one can easily disable neighbor lists to have a working code. However, we should make an effort such that it is possible to reset the neighbor lists after an exchange has been done.

This is related to #26

GiovanniBussi added a commit that referenced this issue Nov 7, 2013
I solved it in the simple way. Instead of asking gromacs
if the exchange has been done or not, I just recompute the neighbor
list explicitly at the step after exchange. This is obtained
by pretending we are on first step in the step after exchange.

Addresses #31 for the case of COORDINATION
GiovanniBussi added a commit that referenced this issue May 27, 2014
I solved it in the simple way. Instead of asking gromacs
if the exchange has been done or not, I just recompute the neighbor
list explicitly at the step after exchange. This is obtained
by pretending we are on first step in the step after exchange.

Addresses #31 for the case of COORDINATION
@GiovanniBussi
Copy link
Member Author

@gtribello @maxbonomi @davidebr @carlocamilloni
I solved this issue long ago for COORDINATION. I think Gareth solved it for multicolvar (Gareth can you confirm?). Possibly only with PATH and PROPERTYMAP this is still to do. I do not have time to solve this now, so unless someone else is willing to do it I will remove this from milestone 2.1

@gtribello
Copy link
Member

I did indeed solve it for multicolvar

@GiovanniBussi
Copy link
Member Author

OK I close this and I reopen one more specific (to be fixed later)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants