Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove reqwest usage in favor of ureq #70

Merged
merged 1 commit into from
Jan 19, 2024
Merged

Remove reqwest usage in favor of ureq #70

merged 1 commit into from
Jan 19, 2024

Conversation

tgross35
Copy link
Contributor

@tgross35 tgross35 commented Oct 18, 2023

Fixes #50

This will also come with a change to using the index https://github.com/pluots/zspell-index/tree/main

@tgross35 tgross35 force-pushed the 50-ureq branch 4 times, most recently from 9bae530 to ff9690c Compare October 18, 2023 16:44
@tgross35 tgross35 force-pushed the 50-ureq branch 4 times, most recently from 2b85842 to 7c4acab Compare January 18, 2024 07:26
Copy link

codecov bot commented Jan 19, 2024

Codecov Report

Attention: 16 lines in your changes are missing coverage. Please review.

Comparison is base (714bb5f) 77.52% compared to head (d496fc9) 76.24%.

Files Patch % Lines
zspell-cli/src/download.rs 87.50% 16 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #70      +/-   ##
==========================================
- Coverage   77.52%   76.24%   -1.29%     
==========================================
  Files          27       27              
  Lines        3511     3376     -135     
==========================================
- Hits         2722     2574     -148     
- Misses        789      802      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Additionally, switch to using an index for locating dictionaries.
@tgross35 tgross35 merged commit 36c946e into main Jan 19, 2024
12 of 13 checks passed
@tgross35 tgross35 deleted the 50-ureq branch January 19, 2024 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch to ureq
1 participant