-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reduce unnecessary log outs #1386
reduce unnecessary log outs #1386
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if you're trying to fix this:
console/assets/src/components/login/Login.tsx
Lines 111 to 113 in 3795335
if (error || (!loading && !data?.clusterInfo)) { | |
return <LoginError error={error} /> | |
} |
Then maybe the better approach is to just trigger the timeout effect if the error is not a network error
79e3395
to
5e57fe3
Compare
good point, I updated it to check for the error I was getting when simulating it. seemed to work correctly when testing. figured checking for any network error might be too big of an umbrella |
1569ec1
to
22376af
Compare
22376af
to
849adf7
Compare
849adf7
to
f227e59
Compare
this was likely causing unnecessary logouts, and we don't necessarily need a logout when LoginError is rendered