Add reparent field to global service controller #913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit 8f25c8b): https://pluralsh-console--pr913-reparent-global-cont-5igex6mm.web.app (expires Sat, 11 May 2024 19:39:47 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: dd1ffa0705acc6ef7d6db370e6bd6fc390e945ce |
Might be useful for cases where you want to have global services take over legacy clusters managed by plural
michaeljguarino
force-pushed
the
reparent-global-controller
branch
from
1c935a2
to
5007832
Compare
michaeljguarino
force-pushed
the
reparent-global-controller
branch
4 times, most recently
from
98606c1
to
e2a51aa
Compare
michaeljguarino
force-pushed
the
reparent-global-controller
branch
3 times, most recently
from
f581b69
to
4d4ed5d
Compare
the current behavior is exclusively an orphan, this allows users to configure deletion for subresources as well.
michaeljguarino
force-pushed
the
reparent-global-controller
branch
from
4d4ed5d
to
8f25c8b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Might be useful for cases where you want to have global services take over legacy clusters managed by plural
Fixes ENG-2039
Test Plan
existing
Checklist