Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default disable kas rewrite in OSS chart #965

Conversation

michaeljguarino
Copy link
Member

This is currently bugged for some users, just get rid of it now that we have the better solve.

Test Plan

n/a

Checklist

  • If required, I have updated the Plural documentation accordingly.
  • I have added tests to cover my changes.
  • I have added a meaningful title and summary to convey the impact of this PR to a user.

This is currently bugged for some users, just get rid of it now that we have the better solve.
@michaeljguarino michaeljguarino added the enhancement New feature or request label May 16, 2024
@michaeljguarino michaeljguarino requested a review from a team May 16, 2024 21:29
Copy link

linear bot commented May 16, 2024

Copy link
Contributor

Visit the preview URL for this PR (updated for commit f93c756):

https://pluralsh-console--pr965-mjg-eng-2079-fix-ngi-dkgp97dv.web.app

(expires Thu, 23 May 2024 21:32:47 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: dd1ffa0705acc6ef7d6db370e6bd6fc390e945ce

@michaeljguarino michaeljguarino merged commit 70ccb08 into master May 17, 2024
11 checks passed
@michaeljguarino michaeljguarino deleted the mjg/eng-2079-fix-nginx-rewrite-for-console-in-marketplace branch May 17, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants