Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement: remove /**/terraform/**/main.tf from default encryption filters #537

Conversation

maciaszczykm
Copy link
Member

It removes /**/terraform/**/main.tf and also /**/terraform/**/main.tf* from default enctryption filters.

Copy link

linear bot commented Aug 26, 2024

@maciaszczykm maciaszczykm added the enhancement New feature or request label Aug 26, 2024
Copy link
Member

@michaeljguarino michaeljguarino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also write the gitattributes file only if it doesn't exist (and same w/ the gitignore file)?

I think it can get in the way of the git agent in the server if it causes a fs change

@michaeljguarino michaeljguarino merged commit 617bfd8 into main Aug 27, 2024
10 of 13 checks passed
@michaeljguarino michaeljguarino deleted the marcin/prod-2567-remove-terraformmaintf-from-default-encryption-filters-in branch August 27, 2024 21:17
michaeljguarino pushed a commit that referenced this pull request Aug 28, 2024
…filters (#537)

* remove /**/terraform/**/main.tf from default encryption filters

* check if files do not exist before write
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants