Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plural pr test command #543

Merged
merged 2 commits into from
Sep 18, 2024
Merged

plural pr test command #543

merged 2 commits into from
Sep 18, 2024

Conversation

zreigz
Copy link
Member

@zreigz zreigz commented Sep 18, 2024

Summary

plural pr test --file /path/to/pr-automation.yaml

Labels

Test Plan

Checklist

  • If required, I have updated the Plural documentation accordingly.
  • I have added tests to cover my changes.
  • I have added a meaningful title and summary to convey the impact of this PR to a user.
  • I have added relevant labels to this PR to help with categorization for release notes.

@zreigz zreigz added the enhancement New feature or request label Sep 18, 2024
Copy link
Member

@michaeljguarino michaeljguarino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall lgtm, minor nit

}
return ci
})
for _, item := range items {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add an intro message to explain what's about to happen. Something like:

utils.Highlight("Lets' fill out the configuration for this PR automation:\n")

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@zreigz zreigz merged commit 6da44fc into main Sep 18, 2024
11 checks passed
@zreigz zreigz deleted the pr-test branch September 18, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants