-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v2.0.3 Undefined is not a function #140
Comments
Please add your gulp task |
I'm having the same error. Gulp-less works when I use node 0.10.36, but doesn't run when I set node 0.12 or IO.js 1.1.0. This is my task.
|
My gulp task gulp.task('less', function() {
gulp.src(paths.lesssrc)
.pipe(less())
.on('error', function (err) {
console.log(err);
})
.pipe(gulp.dest(paths.lessdst));
}); |
@ohJeez looks like your PR broke for node 0.12 and io.js - any ideas? |
Looks like The fix is to move the Regarding 0.10.x, no idea why it still works, looks like node is simply ignoring the .catch and .done, logging the return of .then just gives another chainable .then with no I'm happy to issue a PR, but, like I say, I'm not sure of the original intention of the PR. |
Native promise does not have .done, while then/promise has. Less includes then/promise only if no native promises are available. Quick fix will be replacing |
Yeah, I just did some digging and found the same. You mean replace |
@mattstyles It will work. |
@ohJeez yep, I gotcha, I was just referring to the typo in your earlier comment. |
@ohJeez although, you know that final |
@mattstyles why? It has arguments. |
@ohJeez yeah, but the |
@mattstyles, not if there is another error thrown inside the |
@ohJeez oh yeah, I see now, propagates straight down, makes sense I guess. Although that throws up a slightly different issue, it consumes the error so gulp thinks the less compile has been successful. I cant catch the error in the stream, unless I'm missing something? |
@ohJeez Ignore my previous comment, plumber will catch the error rather than using .on( 'error' ). |
Can you try 3.0.0? @Jenius just sent a major PR which switches us from using less directly to using a less wrapper which handles all of this weird shit. the stuff less exports is a pain to deal with |
I experienced the same error, and it disappeared on 3.0.0. |
🎉 |
ty, 3.0.0 working for me too 👍 |
gulp-less 2.0.1 can't run on node 0.12 or iojs gulp-community/gulp-less#140
Update the version of gulp-less defined in devDependencies to resolve issue describe here - gulp-community/gulp-less#140
Ran into this error when using v2.0.3.
I'm on Mac OSX 10.10 running Node 0.12 64-bit.
The text was updated successfully, but these errors were encountered: