Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix GrantNewAccessTokenFromAuthCode method #44

Merged
merged 3 commits into from
Oct 29, 2017
Merged

Fix GrantNewAccessTokenFromAuthCode method #44

merged 3 commits into from
Oct 29, 2017

Commits on Oct 21, 2017

  1. Correctly handle the case when PayPal returns token expires_in field … 

    …as a string

Credit goes to oauth2 package.
https://github.com/golang/oauth2/blob/master/internal/token.go#L62
    @NicholasAsimov
    NicholasAsimov committed Oct 21, 2017
    Configuration menu
    Copy the full SHA
    6bc1110 View commit details
    Browse the repository at this point in the history

  2. PayPal returns booleans in user info as strings. Notify json unmarsha… 

    …ler about that
    @NicholasAsimov
    NicholasAsimov committed Oct 21, 2017
    Configuration menu
    Copy the full SHA
    ac5b4d7 View commit details
    Browse the repository at this point in the history

  3. Fix GrantNewAccessTokenFromAuthCode method. 

    Changes made:
1. Body is sent as a form-urlencoded values instead of json
2. Basic auth is used for authorization instead of an access token
    @NicholasAsimov
    NicholasAsimov committed Oct 21, 2017
    Configuration menu
    Copy the full SHA
    06b13fe View commit details
    Browse the repository at this point in the history