Remove environment API usage. #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+36
to
+38
| async findStatus() { | ||
| return this._hubRequest.get(`/dfsps/${this._dfspId}/status`); | ||
| } |
There was a problem hiding this comment.
Is this used anywhere? Was it intentionally in this PR?
There was a problem hiding this comment.
Yes, it's used in mojaloop-payment-manager-management-api
Comment on lines
+31
to
+32
| async getHubCA(opts) { | ||
| const url = `/hub/ca`; |
There was a problem hiding this comment.
As it's not mentioned in the discussion, I just want to check that this change is intended to be included in the PR?
There was a problem hiding this comment.
Yes, it's used in mojaloop-payment-manager-management-api
src/package.json
Outdated
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "@modusbox/mcm-client", | |||
| "version": "1.0.34", | |||
| "version": "1.0.35", | |||
There was a problem hiding this comment.
I think this should probably be 2.0, right?
kirgene
requested review from
partiallyordered
and removed request for
bushjames
partiallyordered
approved these changes
Jan 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.