Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] 2.0 #1

Open
wants to merge 34 commits into
base: main
Choose a base branch
from
Open

[WIP] 2.0 #1

wants to merge 34 commits into from

Conversation

pmairoldi
Copy link
Owner

Rewrite app using swift 4 and all the new stuff!

@pmairoldi
Copy link
Owner Author

pmairoldi commented Oct 1, 2017

1 Warning
⚠️ PR is classed as Work in Progress

Generated by 🚫 Danger

@codecov
Copy link

codecov bot commented Oct 1, 2017

Codecov Report

❗ No coverage uploaded for pull request base (master@4d294ed). Click here to learn what that means.
The diff coverage is 60.83%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master       #1   +/-   ##
=========================================
  Coverage          ?   60.83%           
=========================================
  Files             ?       17           
  Lines             ?      720           
  Branches          ?        0           
=========================================
  Hits              ?      438           
  Misses            ?      282           
  Partials          ?        0
Impacted Files Coverage Δ
HockeyPlayoffs/Matchup/MatchupController.swift 0% <0%> (ø)
HockeyPlayoffs/Models/Round.swift 0% <0%> (ø)
HockeyPlayoffs/Models/Teams.swift 0% <0%> (ø)
HockeyPlayoffs/Bracket/BracketDataSource.swift 100% <100%> (ø)
HockeyPlayoffsTests/HockeyPlayoffsTests.swift 100% <100%> (ø)
HockeyPlayoffs/Networking/API.swift 24.32% <24.32%> (ø)
HockeyPlayoffs/Models/Matchup.swift 43.47% <43.47%> (ø)
HockeyPlayoffs/AppDelegate.swift 50% <50%> (ø)
HockeyPlayoffs/Bracket/BracketController.swift 65.85% <65.85%> (ø)
HockeyPlayoffs/AppController.swift 77.77% <77.77%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d294ed...2cf39f1. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant