handle unicode string #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
|
Do you have a PDF that fails on the old code and works on the new code? I could add it to the tests. |
|
I have a few, but unfortunately are all copyrighted. Attempted to use xetex to generated one, but not successful. Will send you one when I found it. |
|
It really wants a unittest in here anyway. I'll add an issue for that. Thanks, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a few regular expression for pdf string.
My project https://github.com/tjwei/translatePDF uses pdfrw and handling a lot of unicode pdf string.
This is a patch that works for handling various Chinese string in pdf.
This patch fixed the following issue:
(\0160) should be parsed as \016 0 not oct(0160), so it should be decoded into \xe30 not max(int(1600, 8), 127).