Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pass requestMethod to the constructor of OperationCoder / OperationTypeCoder #844

Merged
merged 1 commit into from
Apr 10, 2024

Conversation

pmcelhaney
Copy link
Owner

That makes the code a bit easier to follow, particularly in generate.js

…peCoder

That makes the code a bit easier to follow, particularly in generate.js
Copy link

changeset-bot bot commented Apr 10, 2024

⚠️ No Changeset found

Latest commit: d8f490e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 8624385459

Details

  • 24 of 28 (85.71%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.1%) to 86.555%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/typescript-generator/operation-coder.js 11 13 84.62%
src/typescript-generator/operation-type-coder.js 9 11 81.82%
Totals Coverage Status
Change from base Build 8615504453: -0.1%
Covered Lines: 2835
Relevant Lines: 3323

💛 - Coveralls

@pmcelhaney pmcelhaney merged commit 45b2da9 into main Apr 10, 2024
8 checks passed
@pmcelhaney pmcelhaney deleted the refactor-path-coder branch April 10, 2024 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants