Add 'verify' rake task to verify code quality before committing changes #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adangel
reviewed
Jul 26, 2018
| @@ -51,4 +51,6 @@ task 'hoe:spec' do | |||
| File.open("#{hoe.name}.gemspec", "w") { |f| f.write hoe.spec.to_ruby} | |||
| end | |||
|
|
|||
| desc 'verify code quality before committing changes' | |||
| task 'verify' => ['clean', 'test', 'rubocop', 'bundler:gemfile', 'git:manifest'] | |||
There was a problem hiding this comment.
git:manifest would generate the Manifest.txt file. Do we need to have this file then in the repository at all? Could we generate it just before we do rake package maybe?
There was a problem hiding this comment.
Hm...Good idea. But there are some hoe tasks except rake package that may require manifest.txt, so I think it’s good to keep it all the time.
adangel
reviewed
Jul 26, 2018
| Hoe.plugin :bundler | ||
| Hoe.plugin :gemspec |
There was a problem hiding this comment.
Why don't we need hoe-gemspec anymore? I thought, we would require this for creating a ruby gem...
There was a problem hiding this comment.
We create a gemspec file by hoe:spec task now.
adangel
approved these changes
Jul 31, 2018
adangel
added a commit
that referenced
this pull request
Jul 31, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rake verifyis equivalent torake clean test rubocop git:manifest bundler:gemfile