Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[java] Merge Java-grammar into 7.0.x #2788

Merged
merged 1,349 commits into from
Sep 18, 2020
Merged

[java] Merge Java-grammar into 7.0.x #2788

merged 1,349 commits into from
Sep 18, 2020

Conversation

oowekyala
Copy link
Member

Describe the PR

I think, since #2778, we're good to merge java-grammar into the main 7.0 development branch. There are still things to do in #2701, but also in pmd-core, and reducing the overhead of the separate branch is worth it.

If we implement #2518 for PMD 7, then the java API to implement rules will probably change quite a bit. So I'd rather make those changes in PMD core before updating the Java rules. But we can start right now to update XPath rules I think.

Ready?

  • Added unit tests for fixed bug/feature
  • Passing all unit tests
  • Complete build ./mvnw clean verify passes (checked automatically by travis)
  • Added (in-code) documentation (if needed)

@oowekyala
Fix nested ternary with no context
1894435
@oowekyala
Add test for explicit lambda
2b6dd59
@oowekyala
Don't special case standalone ctor/method
886295c
@oowekyala
Fix anonymous class ctor
049cdee
@oowekyala
Add 2 decimals to error rate
b63e7a1
@oowekyala
Test capture in assignment exprs
768b2f6
@oowekyala
Allow field access on type variables
3be2d53
@oowekyala
Remove standalone types for all poly exprs
4aaedf4 
Too many bugs oh god
@oowekyala
Partial revert
2b3cbd7
@oowekyala
Fix the bug
3f31593
@oowekyala
Fix bug with void method refs
b6eed3c
@oowekyala
Cleanup infer
83ac548
@oowekyala
Fix method ref selection
f4f1366
@oowekyala
Test array initializer
00b7a1e
@oowekyala
Cast context doesn't constrain return types anymore
c54faaa
@oowekyala
Add todo
8d41830
@oowekyala
Prefer standalone ternaries
d90ad0a
@oowekyala
Cleanup tests
3940340
@oowekyala
Remove fallback for compile time decl
9511ab0 
We could add it and delete type params. Whatever
@oowekyala
Test varargs on generic array
fd1797a
@oowekyala
Fix generic ctor specificity
e990b22 
Fix precedence of method refs
@oowekyala
Fix method ref on primitive lhs
d4e6daa
@oowekyala
Fix getClass in invocation ctx
c91b9ce
@oowekyala
Fix method ref ambiguity between instance methods
41c8bf8
@oowekyala
Test sam type with default methods
da2b737
@oowekyala
Add todos for raw types
0d936f3
@oowekyala
Really remove fallback
a99698d 
We don't need it
@oowekyala
Preserve unchecked conversion result
07434fd
@oowekyala
Code style
edcb440
@oowekyala
Add fallback but only for invocation
1563fb7
adangel and others added 22 commits September 11, 2020 15:25
@adangel
Merge branch 'pr-2689' into java-grammar
8751271 
[java] New type resolution #2689
@oowekyala
Implement constant expressions
a582504
@oowekyala
Implement references to constant fields
0c8851a
@oowekyala
Fix #520: suppress warnings with const expr
9cf91ba
@oowekyala
Fix tests
1001c4a
@oowekyala
Make sure lambda and mref fallback in invoc context
a1dde27 
This fixes fetchCascaded
@oowekyala
Fix record formal param reference
88db75a 
The assert was too specific
@oowekyala
Merge branch 'typeres-fixes' into java-grammar
53cf812
@oowekyala
Merge branch '7.0.x' into java-grammar
cfb3a37
@oowekyala
Fix tests
82510b7 
Make the symbol resolver explicitly reject
types that have no canonical name. Previously
this was "undefined behavior", meaning, it
could be returning a symbol whose properties
were inconsistent. For example anon classes had
a canonical name...
@oowekyala
Merge branch 'java-grammar' into java-const-values
2da4d4e
@oowekyala
Checkstyle
ea5b18f
@oowekyala
Use ignore annotations for rule tests
1a61698
@oowekyala
Unignore StringToString
05e3baf
@oowekyala
Merge branch '7.0.x' into java-grammar
055aeb3
@adangel
Merge branch 'pmd/7.0.x' into java-grammar
da4d339
@adangel
Merge branch 'pmd/7.0.x' into java-grammar
08d3c0e
@oowekyala
Merge branch 'java-grammar' into use-ignore-annotations-java-grammar
3a5660e
@adangel
Merge branch 'pr-2777' into java-grammar
4820f0c 
[java] Implement constant values #2777
@adangel
Merge branch 'pr-2778' into java-grammar
e81482d 
[java] Use ignore annotations for rule tests #2778
@adangel
Merge branch 'pmd/7.0.x' into java-grammar
9329625
@oowekyala
Remove outdated TODO
1ab7584
@oowekyala oowekyala added this to the 7.0.0 milestone Sep 17, 2020
@pmd-test
Copy link

1 Message
📖 No java rules are changed!

Generated by 🚫 Danger

@adangel adangel self-assigned this Sep 18, 2020
adangel
adangel approved these changes Sep 18, 2020
View reviewed changes
Copy link
Member

@adangel adangel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Will start the merge/push now and delete java-grammar afterwards....

@adangel adangel merged commit 1b13771 into pmd/7.0.x Sep 18, 2020
@adangel adangel deleted the java-grammar branch September 18, 2020 13:58
@oowekyala oowekyala mentioned this pull request Sep 29, 2020
Merged
4 tasks
@adangel adangel mentioned this pull request Jan 23, 2023
Closed
55 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adangel adangel adangel approved these changes

Assignees

@adangel adangel

Labels
None yet
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@oowekyala @pmd-test @adangel