Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Use ruleset loader in pmd 7 #2969

Merged
merged 11 commits into from
Jan 24, 2021
Merged

Conversation

oowekyala
Copy link
Member

@oowekyala oowekyala commented Dec 12, 2020

Describe the PR

Followup on #2635.

  • Use RuleSetLoader everywhere and make RuleSetFactory package-private
  • Refactor RuleSetFactoryCompatibility so that it only does replacements in rule reference attributes, and not the whole file. Make it package private too
  • Remove many APIs deprecated in [core] New RuleSet API and deprecations for PMD's entry point APIs #2635, including RuleSetsFactoryUtils, and RuleSetNotFoundException

Related issues

Ready?

  • Added unit tests for fixed bug/feature
  • Passing all unit tests
  • Complete build ./mvnw clean verify passes (checked automatically by travis)
  • Added (in-code) documentation (if needed)

@oowekyala oowekyala added this to the 7.0.0 milestone Dec 12, 2020
@pmd-test
Copy link

pmd-test commented Dec 12, 2020

2 Messages
📖 Compared to pmd/7.0.x:
This changeset changes 0 violations,
introduces 0 new violations, 0 new errors and 0 new configuration errors,
removes 0 violations, 1 errors and 0 configuration errors.
Full report
📖 Compared to master:
This changeset changes 1606 violations,
introduces 4187 new violations, 1 new errors and 0 new configuration errors,
removes 6137 violations, 10 errors and 2 configuration errors.
Full report
Compared to pmd/7.0.x:
This changeset changes violations,
introduces new violations, new errors and new configuration errors,
removes violations, errors and configuration errors.
Full report
Compared to master:
This changeset changes violations,
introduces new violations, new errors and new configuration errors,
removes violations, errors and configuration errors.
Full report

Generated by 🚫 Danger

@oowekyala oowekyala marked this pull request as ready for review December 20, 2020 09:11
adangel added a commit that referenced this pull request Jan 24, 2021
@adangel adangel merged commit 8af7995 into pmd:pmd/7.0.x Jan 24, 2021
@oowekyala oowekyala deleted the pmd7-ruleset-loader branch January 24, 2021 18:46
@adangel adangel added the in:ruleset-xml About the ruleset schema/parser label Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in:ruleset-xml About the ruleset schema/parser
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[core] RulesetFactoryCompatibility stores the whole ruleset file in memory as a string
3 participants