Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[java] Fix #4200 and #4201: ClassWithOnlyPrivateConstructorsShouldBeFinal, CommentDefaultAccessModifier: Exclude lombok @Value annotation #4202

Merged
merged 4 commits into from
Nov 11, 2022

Conversation

LynnBroe
Copy link
Contributor

@LynnBroe LynnBroe commented Nov 10, 2022

Describe the PR

This PR excludes lombok @Value annotation which make class final and make field private but can not be checked by PMD

Related issues

Ready?

  • Added unit tests for fixed bug/feature
  • Passing all unit tests
  • Complete build ./mvnw clean verify passes (checked automatically by github actions)
  • Added (in-code) documentation (if needed)

@pmd-test
Copy link

pmd-test commented Nov 10, 2022

1 Message
📖 Compared to master:
This changeset changes 0 violations,
introduces 0 new violations, 0 new errors and 0 new configuration errors,
removes 1 violations, 2 errors and 0 configuration errors.
Full report
Compared to master:
This changeset changes 0 violations,
introduces 0 new violations, 0 new errors and 0 new configuration errors,
removes 1 violations, 2 errors and 0 configuration errors.
Full report
Compared to master:
This changeset changes 0 violations,
introduces 0 new violations, 0 new errors and 0 new configuration errors,
removes 1 violations, 2 errors and 0 configuration errors.
Full report
Compared to master:
This changeset changes 0 violations,
introduces 0 new violations, 0 new errors and 0 new configuration errors,
removes 0 violations, 2 errors and 0 configuration errors.
Full report

Generated by 🚫 Danger

@LynnBroe LynnBroe changed the title Fix #4200 [java] ClassWithOnlyPrivateConstructorsShouldBeFinal: Exclude lombok @Value annotation Fix #4200 and #4201 [java] ClassWithOnlyPrivateConstructorsShouldBeFinal,CommentDefaultAccessModifier : Exclude lombok @Value annotation Nov 10, 2022
@adangel adangel changed the title Fix #4200 and #4201 [java] ClassWithOnlyPrivateConstructorsShouldBeFinal,CommentDefaultAccessModifier : Exclude lombok @Value annotation [java] Fix #4200 and #4201: ClassWithOnlyPrivateConstructorsShouldBeFinal,CommentDefaultAccessModifier : Exclude lombok @Value annotation Nov 11, 2022
@adangel adangel added this to the 6.52.0 milestone Nov 11, 2022
@adangel adangel changed the title [java] Fix #4200 and #4201: ClassWithOnlyPrivateConstructorsShouldBeFinal,CommentDefaultAccessModifier : Exclude lombok @Value annotation [java] Fix #4200 and #4201: ClassWithOnlyPrivateConstructorsShouldBeFinal, CommentDefaultAccessModifier: Exclude lombok @Value annotation Nov 11, 2022
Copy link
Member

@adangel adangel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good!

@adangel adangel merged commit 6234b15 into pmd:master Nov 11, 2022
adangel added a commit that referenced this pull request Nov 11, 2022
adangel added a commit that referenced this pull request Nov 11, 2022
[java] Fix #4200 and #4201: ClassWithOnlyPrivateConstructorsShouldBeFinal, CommentDefaultAccessModifier: Exclude lombok @value annotation #4202
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants