-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cli] Move CLI progressbar rendering to pmd-cli #4233
Conversation
- Took the chance to improve how we render it - Added support for interactive terminals - Improved the overall performance / thread-safety of report rendering to STDOUT
pmd-core/src/main/java/net/sourceforge/pmd/reporting/GlobalAnalysisListener.java
Outdated
Show resolved
Hide resolved
pmd-cli/src/main/java/net/sourceforge/pmd/cli/commands/internal/PmdCommand.java
Outdated
Show resolved
Hide resolved
Generated by 🚫 Danger |
pmd-core/src/main/java/net/sourceforge/pmd/reporting/FileAnalysisListener.java
Show resolved
Hide resolved
pmd-core/src/main/java/net/sourceforge/pmd/reporting/GlobalAnalysisListener.java
Show resolved
Hide resolved
Is #3913 also resolved with this PR? If I understand it correctly (please correct me otherwise): The progress bar will be automatically disabled when we report to stdout. It will stay enabled, when we report into a file ( Hm... I think, #3913 is about when running PMD within a non-interactive terminal. With this PR, the progress bar will be displayed using |
Right now progress bar is ON by default. We may decide to change that, and either have it OFF by default, or on by default for interactive consoles only (both plausible). Either scenario would solve #3913, but in the meantime it is still an issue. In any case, we don't need a new |
Thanks for clarifying! 👍 |
pmd-cli/src/main/java/net/sourceforge/pmd/cli/commands/internal/PmdCommand.java
Outdated
Show resolved
Hide resolved
pmd-cli/src/main/java/net/sourceforge/pmd/cli/commands/internal/PmdCommand.java
Show resolved
Hide resolved
Co-authored-by: Clément Fournier <clement.fournier@tu-dresden.de>
[cli] Move CLI progressbar rendering to pmd-cli #4233
Describe the PR
Related issues
Ready?
./mvnw clean verify
passes (checked automatically by github actions)