Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Remove deprecated classes/methods (finish #881) #4342

Merged
merged 4 commits into from
Jan 24, 2023

Conversation

adangel
Copy link
Member

@adangel adangel commented Jan 18, 2023

Describe the PR

These are the small things, that are open from #881. After this PR has been merged, #881 can be closed.

Note: There are many more cleanups (removing deprecated classes/methods) that should be done before the PMD 7 release. But I don't want to make #881 bigger and simply finish it.

Related issues

@adangel adangel added the in:pmd-internals Affects PMD's internals label Jan 18, 2023
@adangel adangel added this to the 7.0.0 milestone Jan 18, 2023
It was only used be the old ui viewer, which was removed with pmd#1431 already
@adangel adangel force-pushed the pmd7-issue-881-deprecation-removals branch from 196a27f to 2b1b1c6 Compare January 19, 2023 09:19
@pmd-test
Copy link

1 Warning
⚠️ Running pmdtester failed, this message is mainly used to remind the maintainers of PMD.

Generated by 🚫 Danger

@adangel adangel mentioned this pull request Jan 23, 2023
55 tasks
@jsotuyod
Copy link
Member

jsotuyod commented Jan 24, 2023

I see that some items marked as done in #881 are actually only deprecated, but were never removed form PMD 7:

  • EnumeratedProperty constructors (but actually, the whole class is deprecated)

We should include these to properly close #881

Nevermind, I just saw #4301.

There are plenty other classes and methods marked as @Deprecated or @DeprecatedUntil700 we will have to hunt down and remove before release..

@jsotuyod jsotuyod merged commit 661abf0 into pmd:pmd/7.0.x Jan 24, 2023
@adangel adangel deleted the pmd7-issue-881-deprecation-removals branch January 25, 2023 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in:pmd-internals Affects PMD's internals
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants