[core] Rules with the same regex properties should be equal #4466
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the PR
Found this while upgrading PMD Eclipse Plugin to 7.0.0. In the plugin, we often verify that we have the same ruleset active by executing
RuleSet#equals()
. This doesn't work as soon as a rule usesjava.util.regex.Pattern
based properties. The reason is, thatPattern
doesn't overrideequals
- see also https://stackoverflow.com/questions/52103427/why-these-two-java-util-pattern-are-not-equalReady?
./mvnw clean verify
passes (checked automatically by github actions)