Fix missing INTERFACE_INCLUDE_DIRECTORIES in exported config #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CMAKE_INSTALL_INCLUDEDIR was used before including GNUInstallDirs, causing the first configuration to miss INTERFACE_INCLUDE_DIRECTORIES. Configuring a second time worked, though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CMAKE_INSTALL_INCLUDEDIR was used before including GNUInstallDirs, causing the first configuration to miss INTERFACE_INCLUDE_DIRECTORIES. Configuring a second time worked, though. Tested with CMake 3.17.5.
I haven't included it here, as I think it might be a breaking change for existing users, but I'd also suggest changing the name of the configuration file from Config.cmake to v8pp-config.cmake or v8ppConfig.cmake, as currently it looks like the config filename needs to be included in the find(). e.g. find_package(v8pp REQUIRED CONFIGS Config.cmake)
For the supported filenames, see the "Config mode" section in https://cmake.org/cmake/help/latest/command/find_package.html#search-modes