Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cuda 11.7 and 11.8 to minimum driver version list #108

Merged
merged 3 commits into from
Dec 23, 2022

Conversation

lassoan
Copy link
Contributor

@lassoan lassoan commented Dec 21, 2022

According to https://docs.nvidia.com/cuda/cuda-toolkit-release-notes/index.html, the minimum required version >=450.80.02 (linux) and >=452.39 (Windows) but the requirements for 11.6 were already higher, so this higher version requirement were kept for 11.7, too.

According to https://docs.nvidia.com/cuda/cuda-toolkit-release-notes/index.html, the minimum required version >=450.80.02 (linux) and >=452.39 (Windows) but the requirements for 11.6 were already higher, so this higher version requirement were kept for 11.7, too.
@pmeier
Copy link
Owner

pmeier commented Dec 21, 2022

Hmm, so far we are using table 3, but IIUC you are saying 2 is the one we should be using? Let me confirm that before we move ahead here.

@lassoan
Copy link
Contributor Author

lassoan commented Dec 22, 2022

Sorry, it was my mistake. I've pushed a new commit, now based on table 3. (you probably want to squash the commits and fix up the commit comment)

Copy link
Owner

@pmeier pmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lassoan! I took the liberty to also add support for CUDA 11.8

light_the_torch/_cb.py Show resolved Hide resolved
light_the_torch/_cb.py Show resolved Hide resolved
@pmeier pmeier changed the title Add cuda 11.7 to minimum driver version list Add cuda 11.7 and 11.8 to minimum driver version list Dec 23, 2022
@codecov
Copy link

codecov bot commented Dec 23, 2022

Codecov Report

Merging #108 (c8bba42) into main (095af73) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##            main    #108   +/-   ##
=====================================
  Coverage   83.6%   83.6%           
=====================================
  Files          5       5           
  Lines        354     354           
=====================================
  Hits         296     296           
  Misses        58      58           
Flag Coverage Δ
unit 83.6% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
light_the_torch/_cb.py 90.0% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@pmeier pmeier merged commit 33417c2 into pmeier:main Dec 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants