Add valgrind instrumentation to concurrent_hash_map #476
Conversation
Codecov Report
@@ Coverage Diff @@
## master #476 +/- ##
==========================================
- Coverage 96.7% 96.67% -0.03%
==========================================
Files 34 34
Lines 4061 4065 +4
==========================================
+ Hits 3927 3930 +3
- Misses 134 135 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
What about other places where we call mask().load()/store()? Shouldn;'t we have annotations also there?
Reviewed 1 of 1 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
The commit fix the issue with concurrent_hash_map_rehash_0_helgrind test
vinser52
force-pushed
the
concurrent_hash_map_helgrind_fix
branch
from
9c8a138
to
84d4983
Compare
There was a problem hiding this comment.
I have added more annotations to places where we load with acquire.
Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @igchor)
|
@igchor and @annamarcink please review this pull request |
|
Could you make PR to stable-1.8? |
There was a problem hiding this comment.
Do you mean one more PR or just instead of this one?
Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @igchor)
|
Just this one (we will later merge stable-1.8 to master) |
There was a problem hiding this comment.
Done
Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @igchor)
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @igchor)
The commit fix the issue with concurrent_hash_map_rehash_0_helgrind test
This change is