-
Notifications
You must be signed in to change notification settings - Fork 510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
common: add UBSAN build #5819
common: add UBSAN build #5819
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5819 +/- ##
=======================================
Coverage 71.00% 71.00%
=======================================
Files 131 131
Lines 19175 19175
Branches 3193 3193
=======================================
Hits 13616 13616
Misses 5559 5559 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @osalyk)
.github/workflows/scan_ubsan.yml
line 9 at r1 (raw file):
env:
I believe this new line is redundant.
.github/workflows/scan_ubsan.yml
line 38 at r1 (raw file):
run: cd $WORKDIR && ./pull-or-rebuild-image.sh - name: Build CI with UBSAN
Suggestion:
Build libraries with Undefined Behavior Sanitizer and run tests
.github/workflows/scan_ubsan.yml
line 39 at r1 (raw file):
- name: Build CI with UBSAN run: cd $WORKDIR && TEST_BUILD=${{ matrix.build }} ./build-CI.sh
I prefer using the dedicated env
syntax wherever it is possible.
Suggestion:
- name: Build CI with UBSAN
env:
TEST_BUILD: ${{ matrix.build }}
run: cd $WORKDIR && ./build-CI.sh
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 1 of 2 files reviewed, 3 unresolved discussions (waiting on @janekmi)
.github/workflows/scan_ubsan.yml
line 9 at r1 (raw file):
Previously, janekmi (Jan Michalski) wrote…
I believe this new line is redundant.
Done.
.github/workflows/scan_ubsan.yml
line 38 at r1 (raw file):
run: cd $WORKDIR && ./pull-or-rebuild-image.sh - name: Build CI with UBSAN
Done.
.github/workflows/scan_ubsan.yml
line 39 at r1 (raw file):
Previously, janekmi (Jan Michalski) wrote…
I prefer using the dedicated
env
syntax wherever it is possible.
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @osalyk)
https://github.com/osalyk/pmdk/actions/runs/5622110505/job/15234172907
This change is