-
Notifications
You must be signed in to change notification settings - Fork 510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: fix CHECK_TYPE behaviour #5868
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5868 +/- ##
==========================================
+ Coverage 68.15% 70.99% +2.83%
==========================================
Files 131 131
Lines 19682 19176 -506
Branches 3259 3193 -66
==========================================
+ Hits 13415 13614 +199
+ Misses 6267 5562 -705 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🐐
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @janekmi)
src/test/unittest/unittest.sh
line 51 at r1 (raw file):
# Required for easy force-enable condition failure detection. # Please see require_valgrind() for details. CHECK_TYPE_COPY=$CHECK_TYPE
It is not just a 'copy'. It is expected Valgrind test to be used.
Suggestion:
SPECIFIED_CHECK_TYPE
6505710
to
872a462
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 2 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @grom72)
src/test/unittest/unittest.sh
line 51 at r1 (raw file):
Previously, grom72 (Tomasz Gromadzki) wrote…
It is not just a 'copy'. It is expected Valgrind test to be used.
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @janekmi)
- By default, no Valgrind tool has been forced, and a Valgrind tool or lack of it will be picked depending on the particular test's requirements. - Providing 'force-enable [memcheck|pmemcheck|helgrind|drd]' will force all tests to be run under the forced Valgrind tool unless a test forced a different Valgrind tool in which case the given will test will be skipped. - Providing 'force-enable none' will run all tests that do not require explicitly any Valgrind tool and skip all other tests. Ref: #5811 Ref: #5791 Signed-off-by: Jan Michalski <jan.michalski@intel.com>
Ref: #5811
Ref: #5791
No
force-enable
provided - regression and fixPMem Long (no force-enable provided)
Before regression: https://github.com/pmem/pmdk/actions/runs/5838427329/job/15835451743
After regression: https://github.com/pmem/pmdk/actions/runs/5908491536/job/16027995086
After fix: https://github.com/pmem/pmdk/actions/runs/5927643088/job/16071573582
Explicit
force-enable
is provided - no changePMem Valgrind (force-enable: none)
Before fix: https://github.com/pmem/pmdk/actions/runs/5925859348/job/16066125162#step:6:125
After fix: https://github.com/pmem/pmdk/actions/runs/5927719561/job/16071794659#step:6:125
PMem Valgrind (force-enable: pmemcheck)
Before fix: https://github.com/pmem/pmdk/actions/runs/5914014610/job/16038896782
After fix: https://github.com/pmem/pmdk/actions/runs/5927719561/job/16071794960
This change is