-
Notifications
You must be signed in to change notification settings - Fork 21
Suspended refs inode #419
base: master
Are you sure you want to change the base?
Suspended refs inode #419
Conversation
Codecov Report
@@ Coverage Diff @@
## master #419 +/- ##
==========================================
- Coverage 79.46% 79.08% -0.38%
==========================================
Files 71 71
Lines 8749 8861 +112
Branches 1769 1799 +30
==========================================
+ Hits 6952 7008 +56
- Misses 1349 1380 +31
- Partials 448 473 +25
Continue to review full report at Codecov.
|
src/libpmemfile-posix/inode.c
Outdated
|
||
if (vinode->orphaned.arr) | ||
vinode->orphaned.arr = | ||
add_off(vinode->orphaned.arr, diff); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removal of this seems to be accidental.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
@@ -294,9 +303,6 @@ struct pmemfile_super { | |||
/* list of arrays of inodes that were deleted, but are still opened */ | |||
TOID(struct pmemfile_inode_array) orphaned_inodes; | |||
|
|||
/* list of arrays of inodes that are suspended */ | |||
TOID(struct pmemfile_inode_array) suspended_inodes; | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please bump file system version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, forgot about that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
d685acc
to
dfc8705
Compare
Reviewed 13 of 18 files at r1. src/libpmemfile-posix/pool.c, line 357 at r1 (raw file):
Just use tinode->oid.pool_uuid_lo and tinode->oid.off. There's no need for memcpy. src/libpmemfile-posix/pool.c, line 409 at r1 (raw file):
file->vinode->inode.oid.off src/libpmemfile-posix/pool.c, line 413 at r1 (raw file):
Please set errno. src/libpmemfile-posix/pool.c, line 486 at r1 (raw file):
Please move this line to before "if (file_at != NULL)" src/libpmemfile-posix/pool.c, line 544 at r1 (raw file):
Can we do it just before the transaction and hold a lock for the duration of transaction? src/libpmemfile-posix/pool.c, line 585 at r1 (raw file):
file->vinode->inode.oid.off ... or actually store file->vinode->inode. src/libpmemfile-posix/unlink.c, line 222 at r1 (raw file):
This is racy. Take the lock before looking at vinode->blocks. tests/posix/suspend_resume/suspend_resume.cpp, line 73 at r1 (raw file):
Please use ASSERT_EQ. tests/posix/suspend_resume/suspend_resume.cpp, line 126 at r1 (raw file):
We know how many bytes are going to be read (because we pad those values with zeroes), so why not use ASSERT_EQ? tests/posix/suspend_resume/suspend_resume.cpp, line 134 at r1 (raw file):
Please verify there are no other lines. Comments from Reviewable |
They are not only available inside read.c or write.c anymore.
dfc8705
to
c694c15
Compare
Review status: 4 of 18 files reviewed at latest revision, 10 unresolved discussions. src/libpmemfile-posix/pool.c, line 413 at r1 (raw file): Previously, marcinslusarz (Marcin Ślusarz) wrote…
Done. src/libpmemfile-posix/pool.c, line 486 at r1 (raw file): Previously, marcinslusarz (Marcin Ślusarz) wrote…
Done. src/libpmemfile-posix/unlink.c, line 222 at r1 (raw file): Previously, marcinslusarz (Marcin Ślusarz) wrote…
Done. tests/posix/suspend_resume/suspend_resume.cpp, line 73 at r1 (raw file): Previously, marcinslusarz (Marcin Ślusarz) wrote…
Done. Comments from Reviewable |
This change is