Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allocate Client structure from DRAM #144

Merged

Conversation

jschmieg
Copy link

@jschmieg jschmieg commented Mar 17, 2020

This change is Reviewable

Copy link

@michalbiesek michalbiesek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved


src/networking.c, line 88 at r1 (raw file):

client *createClient(connection *conn) {
    client *c = zmalloc_dram(sizeof(client));

This is not related with this PR, but just to let you know I saw "simillar code" related to AOF functionality:

redis/src/aof.c

Line 657 in 555481c

struct client *c = zmalloc(sizeof(*c));

I did not spend time to analyze this but maybe this code should also be updated.

Copy link

@michalbiesek michalbiesek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@jschmieg jschmieg merged commit c40ebf7 into pmem:6.0-memkind_alloc_by_size May 19, 2020
PatKamin added a commit to PatKamin/redis that referenced this pull request Sep 27, 2022
[4.0.7-devel] Fix tarball naming
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants