examples: add common-pmem_map_file and signature_check to example09

[haichangsi]

This change is 

[grom72]

Reviewed 3 of 4 files at r1.
Reviewable status: 3 of 4 files reviewed, 3 unresolved discussions (waiting on @haichangsi and @osalyk)

---

examples/09-flush-to-persistent-GPSPM/CMakeLists.txt line 43 at r1 (raw file):

link_directories(${LIBRPMA_LIBRARY_DIRS})

function(add_example name)

have not we talked already to move this function to a common location?

Code quote:

function(add_example name)

---

examples/09-flush-to-persistent-GPSPM/client.c line 301 at r1 (raw file):

#ifdef USE_PMEM
	if (mem.is_pmem) {
		common_pmem_unmap_file(&mem);

Suggestion:

#ifdef USE_PMEM
	if (mem.is_pmem) {
		common_pmem_unmap_file(&mem);
	} else
#endif /* USE_PMEM */

---

examples/09-flush-to-persistent-GPSPM/server.c line 244 at r1 (raw file):

#else
	(void) printf(
			"At this point, persist function should be called if libpmem2 or libpmem will be in use\n");

Suggestion:

persistent memory

[grom72]

Reviewed 1 of 4 files at r1, all commit messages.
Reviewable status: 3 of 4 files reviewed, 3 unresolved discussions (waiting on @haichangsi and @osalyk)

[osalyk]

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @grom72 and @haichangsi)

---

examples/09-flush-to-persistent-GPSPM/CMakeLists.txt line 43 at r1 (raw file):

Previously, grom72 (Tomasz Gromadzki) wrote…

have not we talked already to move this function to a common location?

+1 add_example_with_pmem()

---

examples/09-flush-to-persistent-GPSPM/client.c line 134 at r1 (raw file):

	if ((ret = rpma_mr_reg(peer, msg_ptr, KILOBYTE,
			RPMA_MR_USAGE_SEND | RPMA_MR_USAGE_RECV,
			&msg_mr))) {

if ((ret = rpma_mr_reg(peer, msg_ptr, KILOBYTE, RPMA_MR_USAGE_SEND | RPMA_MR_USAGE_RECV,
&msg_mr))) {

Please correct all similar cases

Code quote:

	if ((ret = rpma_mr_reg(peer, msg_ptr, KILOBYTE,
			RPMA_MR_USAGE_SEND | RPMA_MR_USAGE_RECV,
			&msg_mr))) {

[grom72]

Reviewed 1 of 4 files at r1.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @grom72 and @haichangsi)

[haichangsi]

Reviewable status: 3 of 4 files reviewed, 4 unresolved discussions (waiting on @grom72 and @osalyk)

---

examples/09-flush-to-persistent-GPSPM/CMakeLists.txt line 43 at r1 (raw file):

Previously, osalyk (Oksana Sałyk) wrote…

+1 add_example_with_pmem()

Done.

---

examples/09-flush-to-persistent-GPSPM/client.c line 134 at r1 (raw file):

Previously, osalyk (Oksana Sałyk) wrote…

if ((ret = rpma_mr_reg(peer, msg_ptr, KILOBYTE, RPMA_MR_USAGE_SEND | RPMA_MR_USAGE_RECV,
&msg_mr))) {

Please correct all similar cases

Done.

---

examples/09-flush-to-persistent-GPSPM/client.c line 301 at r1 (raw file):

#ifdef USE_PMEM
	if (mem.is_pmem) {
		common_pmem_unmap_file(&mem);

Done.

---

examples/09-flush-to-persistent-GPSPM/server.c line 244 at r1 (raw file):

#else
	(void) printf(
			"At this point, persist function should be called if libpmem2 or libpmem will be in use\n");

Done.

[haichangsi]

Reviewable status: 2 of 4 files reviewed, 4 unresolved discussions (waiting on @grom72, @ldorau, and @osalyk)

---

examples/09-flush-to-persistent-GPSPM/CMakeLists.txt line 43 at r1 (raw file):

Previously, haichangsi (Haichang) wrote…

Done.

no, you are wrong, as we discussed with @ldorau in this example we use libprotobuf so I had to leave it the way it is

[haichangsi]

Ref: #1791

Reviewable status: 2 of 4 files reviewed, 4 unresolved discussions (waiting on @grom72, @ldorau, and @osalyk)

[grom72]

Reviewed 2 of 2 files at r3, 1 of 2 files at r4, 1 of 1 files at r5.
Reviewable status: all files reviewed (commit messages unreviewed), 2 unresolved discussions (waiting on @haichangsi and @osalyk)

---

examples/09-flush-to-persistent-GPSPM/CMakeLists.txt line 44 at r5 (raw file):

link_directories(${LIBRPMA_LIBRARY_DIRS})

add_example_with_pmem(server server.c GPSPM_flush.pb-c.c ../common/common-conn.c)

what about options USE_LIBPROTOBUFC?

Suggestion:

add_example_with_pmem(server server.c GPSPM_flush.pb-c.c ../common/common-conn.c USE_LIBPROTOBUFC)
add_example_with_pmem(client client.c GPSPM_flush.pb-c.c ../common/common-conn.c USE_LIBPROTOBUFC)

[grom72]

Reviewed all commit messages.
Reviewable status: 4 of 5 files reviewed, 1 unresolved discussion (waiting on @grom72 and @osalyk)

[grom72]

Reviewed 1 of 1 files at r6.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @osalyk)

[haichangsi]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @osalyk)

---

examples/09-flush-to-persistent-GPSPM/CMakeLists.txt line 44 at r5 (raw file):

Previously, grom72 (Tomasz Gromadzki) wrote…

what about options USE_LIBPROTOBUFC?

It is a bigger problem, I've tried many solutions on the second branch, none of them works

[grom72]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @osalyk)

---

examples/09-flush-to-persistent-GPSPM/CMakeLists.txt line 44 at r5 (raw file):

Previously, haichangsi (Haichang) wrote…

It is a bigger problem, I've tried many solutions on the second branch, none of them works

Let's move to intersprint

[ldorau]

Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @haichangsi and @osalyk)

---

examples/09-flush-to-persistent-GPSPM/CMakeLists.txt line 44 at r6 (raw file):

link_directories(${LIBRPMA_LIBRARY_DIRS})

add_example_with_pmem(server server.c GPSPM_flush.pb-c.c ../common/common-conn.c USE_LIBPROTOBUFC)

USE_LIBPROTOBUFC is not a source file

Code quote:

USE_LIBPROTOBUFC

---

examples/09-flush-to-persistent-GPSPM/CMakeLists.txt line 45 at r6 (raw file):

add_example_with_pmem(server server.c GPSPM_flush.pb-c.c ../common/common-conn.c USE_LIBPROTOBUFC)
add_example_with_pmem(client client.c GPSPM_flush.pb-c.c ../common/common-conn.c USE_LIBPROTOBUFC)

.

Code quote:

USE_LIBPROTOBUFC

[ldorau]

Reviewed 1 of 1 files at r6.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @haichangsi and @osalyk)

[ldorau]

Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @haichangsi and @osalyk)

---

examples/09-flush-to-persistent-GPSPM/CMakeLists.txt line 44 at r6 (raw file):

Previously, ldorau (Lukasz Dorau) wrote…

USE_LIBPROTOBUFC is not a source file

It seems that add_example_with_pmem() should be fixed.

Code quote:

add_example_with_pmem

[osalyk]

Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @haichangsi)

[haichangsi]

Reviewable status: 3 of 8 files reviewed, 2 unresolved discussions (waiting on @grom72, @ldorau, and @osalyk)

---

examples/09-flush-to-persistent-GPSPM/CMakeLists.txt line 44 at r6 (raw file):

Previously, ldorau (Lukasz Dorau) wrote…

It seems that add_example_with_pmem() should be fixed.

Done.

---

examples/09-flush-to-persistent-GPSPM/CMakeLists.txt line 45 at r6 (raw file):

Previously, ldorau (Lukasz Dorau) wrote…

.

Done.

[codecov]

Codecov Report

Merging #1909 (4a18687) into master (b252e55) will not change coverage.
The diff coverage is n/a.

❗ Current head 4a18687 differs from pull request most recent head 025a67f. Consider uploading reports for the commit 025a67f to get more accurate results

@@            Coverage Diff            @@
##            master     #1909   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           16        16           
  Lines         1425      1424    -1     
=========================================
- Hits          1425      1424    -1     

[grom72]

Reviewed 5 of 5 files at r7, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @ldorau)

[grom72]

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @ldorau)

[ldorau]

Reviewed 1 of 4 files at r1, 2 of 2 files at r3, 5 of 5 files at r7, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @haichangsi)

a discussion (no related file):
The first commit does not build:
https://github.com/ldorau/rpma/actions/runs/2697237557

Each and every commit has to build correctly.
You should not submit one commit with bugs and the next one with fixes.
Squash them please.

---

[haichangsi]

Reviewable status: all files reviewed (commit messages unreviewed), 1 unresolved discussion (waiting on @ldorau)

a discussion (no related file):

Previously, ldorau (Lukasz Dorau) wrote…

The first commit does not build:
https://github.com/ldorau/rpma/actions/runs/2697237557

Each and every commit has to build correctly.
You should not submit one commit with bugs and the next one with fixes.
Squash them please.

I know. In the beggining it was like that:
1st one - changes to both client and server (bulding correctly)
2nd - cmake changes (now also building correctly)
Maybe during this whole process sth has changed. Sorry. Done.

---

[ldorau]

Reviewed all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @haichangsi)

---

-- commits line 4 at r8:
use capital letters

Code quote:

use_libprotobufc

[haichangsi]

Reviewable status: all files reviewed (commit messages unreviewed), 1 unresolved discussion (waiting on @ldorau)

---

-- commits line 4 at r8:

Previously, ldorau (Lukasz Dorau) wrote…

use capital letters

Done.

[ldorau]

Reviewed all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @haichangsi)

[ldorau]

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @haichangsi)