-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Symmetrization failed #4
Comments
Thanks for reporting this. It is a silly bug in the Minkowski reduction code. I am working on a fix. |
I have fixed the bug. I have also added a more specific error message so this type of bug can be more easily identified in future. |
Many thanks Peter! With the most recent version just pushed, the cell above is now fixed, but I do get a
These were the only two cells I could find that failed. |
Thanks for the feedback. I will do some more testing. This is clearly no good! |
It should be resolved now. There were two bugs:
|
Many thanks Peter! Regarding the reduction, is there a reason it has to be a Minkowski reduction? We have LLL reduction implemented ourselves, I'm just wondering if it would be worthwhile for us to add Minkowski (I'm not sure when one might need to use one over the other or what the distinction is, other than that LLL is fast, and that perhaps Minkowski is more strict(?)). |
Minkowski reduction describes the lattice with the shortest possible set of vectors. LLL is less strict, guaranteeing only that:
Minkowski reduction is pretty handy for other things too. If you want to find the nearest neighbours of an atom, you can restrict the search to the 27 adjacent cells of a Minkowski-reduced cell. I recently changed ASE's |
Hello,
Thanks for the excellent code and paper, which is very interesting.
I was trying out Auguste and it seems to work on 99% of cells but I sometimes receive a
symmetrization failed
error. Is it expected that symmetrization would fail in some cases?For example, consider this cell:
Separately, the pip install doesn't work on macOS without manually modifying the setup.py to set
MACOSX_DEPLOYMENT_TARGET
.Many thanks!
The text was updated successfully, but these errors were encountered: