Fix points raycast #1342
Merged
Fix points raycast #1342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are two issues: 1. `_position` is the the world position. In the original code, _position is retrieved from the bufferattribute which is local position 2. the matrix that is applied in the original code is the parent matrixWorld. This is also in line with the line 58.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit bfc762d:
|
drcmda
reviewed
Mar 14, 2023
Would be more correct since we're using the class' local transforms. The difference between the two lines is whether the ray should do the same or exist as a sibling of the same parent.
|
@promontis is this done? |
|
This version is better than the current version, so you might want to merge it in. I'm currently running in a couple of problems with this code, namely:
|
|
🎉 This PR is included in version 9.66.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two issues:
_positionis the world position. In the original code, _position is retrieved from the bufferattribute which is local positionthe matrix that is applied in the original code is the parent matrixWorld. This is also in line with the line 58.