-
Notifications
You must be signed in to change notification settings - Fork 670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat/add scale ratio for useSpriteLoader #2002
Merged
netgfx
merged 28 commits into
pmndrs:master
from
netgfx:feat/add-scale-ratio-for-useSpriteLoader
Jun 20, 2024
Merged
feat/add scale ratio for useSpriteLoader #2002
netgfx
merged 28 commits into
pmndrs:master
from
netgfx:feat/add-scale-ratio-for-useSpriteLoader
Jun 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
🎉 This PR is included in version 9.107.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
useSpriteLoader now has the ability to support trimmed spritesheets as it calculates the largest frame and adds a scale-ratio for the rest, this way the texture can be scaled up and down in order to match its initial size (something that we get for free when dealing with same size frames). This is a big improvement as we can now support trimmed sprites to reduce memory usage.
What
Added an extra property per frame called
scaleRatio
which has a value between 0 and 1 depending on the size of the frame when compared to the largest frame, it will be 1 when dealing with same size frames.Checklist