Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TypeScript issue on gltf models with animations. #60

Closed
Code47X opened this issue Dec 21, 2020 · 2 comments
Closed

TypeScript issue on gltf models with animations. #60

Code47X opened this issue Dec 21, 2020 · 2 comments

Comments

@Code47X
Copy link
Contributor

Code47X commented Dec 21, 2020

Not sure if Drei has changed useAnimations recently, but there seems to be a typescript error with the default gltf-jsx output for models with animations.

image

image
@Code47X Code47X changed the title TypeScript issues on gltf models with animations. TypeScript issue on gltf models with animations. Dec 21, 2020
@drcmda
Copy link
Member

drcmda commented Dec 21, 2020

could you fix it and make it a pr? i don't know enough ts to really do anything about it.

@Code47X
Copy link
Contributor Author

Code47X commented Dec 21, 2020

It seems like just typecasting the group ref as MutableRefObject<THREE.Object3D> does the trick.

image

@Code47X Code47X mentioned this issue Jan 11, 2021
Merged
@Code47X Code47X closed this as completed Jan 12, 2021
@Code47X Code47X mentioned this issue Jan 14, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@drcmda @Code47X