Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

useTwixSettings #13

Closed
gsimone opened this issue Nov 10, 2020 · 2 comments
Closed

useTwixSettings #13

gsimone opened this issue Nov 10, 2020 · 2 comments

Comments

@gsimone
Copy link
Member

gsimone commented Nov 10, 2020 •
edited
Loading

More complex use cases might need complex settings/configuration, we can use a hook that can be called multiple times - ideally one - and settings are merged:

useTwixSettings({ container: ref, theme: "red-hot", onChange: serialize })

Related to #17
@gsimone gsimone mentioned this issue Nov 10, 2020
Open
@dbismut
Copy link
Collaborator

dbismut commented Nov 10, 2020

Maybe this should live as a Provider? We should make sure that that hook is called once in the render tree right?

@gsimone gsimone mentioned this issue Dec 23, 2020
Closed
@dbismut dbismut mentioned this issue Dec 25, 2020
Merged
@gsimone
Copy link
Member Author

gsimone commented Dec 26, 2020

CLosing this in favor of always using the comp

@gsimone gsimone closed this as completed Dec 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gsimone @dbismut