Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement ColorDepthEffect #589

Closed
3 tasks done
Tracked by #600
vanruesc opened this issue Feb 16, 2024 · 3 comments
Closed
3 tasks done
Tracked by #600

Implement ColorDepthEffect #589

vanruesc opened this issue Feb 16, 2024 · 3 comments
Assignees
@benjamin-white
Labels
feature Description for the implementation of a feature
Milestone
v7

Comments

@vanruesc
Copy link
Member

vanruesc commented Feb 16, 2024 •
edited
Loading

Description

Implement a ColorDepthEffect.

Tasks

  • Create ColorDepthEffect.
  • Create color-depth demo.
  • Add unit test.

Implementation Details

  • The implementation from v6 can be copied mostly as-is.
@vanruesc vanruesc added the feature Description for the implementation of a feature label Feb 16, 2024
@vanruesc vanruesc added this to the v7 milestone Feb 16, 2024
@vanruesc vanruesc mentioned this issue Feb 17, 2024
Open
33 tasks
@benjamin-white
Copy link

Hello, I'd like to take a look at this one if that's ok please?

@vanruesc
Copy link
Member Author

Sure, have fun 👍

@benjamin-white benjamin-white mentioned this issue Feb 22, 2024
Merged
@benjamin-white
Copy link

Great thanks @vanruesc

I have opened a PR here: #604 If it's generally the right shape let me know, if not, no worries :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benjamin-white benjamin-white

Labels
feature Description for the implementation of a feature
Projects
None yet
Milestone
v7
Development

No branches or pull requests
2 participants
@vanruesc @benjamin-white