Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Degradation] Attachements detaching invalid #33

Closed
eXponenta opened this issue May 31, 2022 · 1 comment
Closed

[Degradation] Attachements detaching invalid #33

eXponenta opened this issue May 31, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@eXponenta
Copy link
Contributor

eXponenta commented May 31, 2022 •
edited
Loading

Critical Bug in 0.0.3
See:
https://github.com/pmndrs/react-ogl/blob/main/src/utils.ts#L84

There are not a __r3f field in child because there are not a place where it is assigned.

This is down when we copy node with attachments.

Then this place not required because we remove a __previousAttach above

https://github.com/pmndrs/react-ogl/blob/main/src/utils.ts#L86
@eXponenta eXponenta changed the title [Critical] Attachements detaching invalid [Degradation] Attachements detaching invalid May 31, 2022
@CodyJasonBennett
Copy link
Member

Published a patch in 0.3.2.

@CodyJasonBennett CodyJasonBennett added the bug Something isn't working label May 31, 2022
@eXponenta eXponenta mentioned this issue May 31, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@eXponenta @CodyJasonBennett