Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

springs doesn't work if Canvas doesn't persist and three animated(...) was invoked somewhere in the project [bug]: #2001

Closed
2 of 5 tasks
mordv opened this issue Oct 22, 2022 · 1 comment
Labels
template: bug This issue might be a bug

Comments

@mordv
Copy link

mordv commented Oct 22, 2022

Which react-spring target are you using?

  • @react-spring/web
  • @react-spring/three
  • @react-spring/native
  • @react-spring/konva
  • @react-spring/zdog

What version of react-spring are you using?

9.5.5

What's Wrong?

If somewhere in the project HOC for fiber was created:
const AnimatedBox = animatedThree(Box)

The animation is dead for all web pages without the fiber's Canvas

To Reproduce

Reproduced in codesanbox.
Try to comment out 9 line of codesandbox example - the thing will work as expected.

Expected Behaviour

I expect that custom animated components wouldn't have any effect on pages without theejs.

Link to repo

https://codesandbox.io/s/optimistic-clarke-urfiic?file=/src/App.tsx:344-382

@mordv mordv added the template: bug This issue might be a bug label Oct 22, 2022
@joshuaellis
Copy link
Member

Thanks for the report @mordv, this is a duplicate of #1586, here's a workaround whilst I work on a fix – #1586 (comment)

@joshuaellis joshuaellis closed this as not planned Won't fix, can't repro, duplicate, stale Oct 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
template: bug This issue might be a bug
Projects
None yet
Development

No branches or pull requests

2 participants