Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Props to CanvasProps #2434

Merged

Conversation

hmans
Copy link
Contributor

@hmans hmans commented Aug 12, 2022

  • Renames the somewhat generically named Props interfaces from both Canvas.tsx modules to a more specific CanvasProps.
  • The (minor) unrelated formatting changes were, I think/hope, Prettier picking up the repository's .prettierrc.
  • Changeset included.

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 2e5df68:

Sandbox Source
example Configuration

@hmans
Copy link
Contributor Author

hmans commented Aug 12, 2022

It is very hard for me to say if the test failure was caused by my change. What I can say is that tests run fine locally.

Copy link
Member

@CodyJasonBennett CodyJasonBennett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't mind CI there. That's present on the v9 branch but not locally or in #2378. Will investigate that later.

@CodyJasonBennett CodyJasonBennett merged commit b88631e into pmndrs:v9 Aug 12, 2022
@hmans hmans deleted the give-canvas-props-more-explicit-name branch August 12, 2022 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants