-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v9] fix: Euler types and ReactProps #2705
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 56a11a9:
|
Would it be error prone to loosen |
interface ReactProps<P> { | ||
export interface ReactProps<P> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BTW how were you getting error TS4023: Exported variable {ComponentName} has or is using name 'ReactProps' from external module "C:/dev/nt--drei/node_modules/@react-three/fiber/dist/declarations/src/three-types" but cannot be named.
? Is this with PNPM and symlinks?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is with the Drei repo in the base src folder using yarn and no symlinks (afaik). There must be a better solution than this, but this worked. :)
Wouldn't this mean any instance with a |
I'm happy to merge this. I do suspect a similar issue with #2668 (comment). |
I think so too. Okay, let's merge and make adjustments going forward. I'll see if we can rollback exporting |
This does three things to fix types.
Adds an export to
ReactProps
to fixerror TS4023: Exported variable {ComponentName} has or is using name 'ReactProps' from external module "C:/dev/nt--drei/node_modules/@react-three/fiber/dist/declarations/src/three-types" but cannot be named.
Is this a bug with lerna multi package project with TS4053 error? microsoft/TypeScript#40718
XXX has or is using name 'Foo' from external module "../bar" but cannot be named microsoft/TypeScript#9944
Makes MathRepresenation a union with
THREE.Euler
since it's optionalorder
string parameter throws a wrench in any algorithmic detection as far as I can see.Adds a MathType Euler export so
ReactThreeFiber.Euler
works.