Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(native): revert usage of networking stack #3042

Merged
merged 2 commits into from
Oct 17, 2023

Conversation

CodyJasonBennett
Copy link
Member

@CodyJasonBennett CodyJasonBennett commented Oct 12, 2023

Partial revert of #2982 which is producing undefined promise rejections somewhere in the network stack.

We'll revisit once things improve upstream and look into useLoader overloads via Loader#parse in the meantime.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 12, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 4d3e9ee:

Sandbox Source
example Configuration

@CodyJasonBennett CodyJasonBennett marked this pull request as draft October 12, 2023 23:35
@CodyJasonBennett CodyJasonBennett marked this pull request as ready for review October 17, 2023 23:15
@CodyJasonBennett CodyJasonBennett changed the title experiment(native): revert usage of networking stack fix(native): revert usage of networking stack Oct 17, 2023
@CodyJasonBennett CodyJasonBennett linked an issue Oct 17, 2023 that may be closed by this pull request
@CodyJasonBennett CodyJasonBennett merged commit d1e5436 into master Oct 17, 2023
2 checks passed
@CodyJasonBennett CodyJasonBennett deleted the fix/native-polyfills branch October 17, 2023 23:21
renovate bot added a commit to ziyadedher/ziyadedher that referenced this pull request Oct 18, 2023
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [@react-three/fiber](https://togithub.com/pmndrs/react-three-fiber) |
[`8.14.5` ->
`8.14.6`](https://renovatebot.com/diffs/npm/@react-three%2ffiber/8.14.5/8.14.6)
|
[![age](https://developer.mend.io/api/mc/badges/age/npm/@react-three%2ffiber/8.14.6?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@react-three%2ffiber/8.14.6?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@react-three%2ffiber/8.14.5/8.14.6?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@react-three%2ffiber/8.14.5/8.14.6?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>pmndrs/react-three-fiber (@&#8203;react-three/fiber)</summary>

###
[`v8.14.6`](https://togithub.com/pmndrs/react-three-fiber/releases/tag/v8.14.6)

[Compare
Source](https://togithub.com/pmndrs/react-three-fiber/compare/v8.14.5...v8.14.6)

#### What's Changed

- fix(native): revert usage of networking stack by
[@&#8203;CodyJasonBennett](https://togithub.com/CodyJasonBennett) in
[pmndrs/react-three-fiber#3042

**Full Changelog**:
pmndrs/react-three-fiber@v8.14.5...v8.14.6

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/ziyadedher/ziyadedher).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xOS4yIiwidXBkYXRlZEluVmVyIjoiMzcuMTkuMiIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
ziyadedher pushed a commit to ziyadedher/ziyadedher that referenced this pull request Dec 16, 2023
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [@react-three/fiber](https://togithub.com/pmndrs/react-three-fiber) |
[`8.14.5` ->
`8.14.6`](https://renovatebot.com/diffs/npm/@react-three%2ffiber/8.14.5/8.14.6)
|
[![age](https://developer.mend.io/api/mc/badges/age/npm/@react-three%2ffiber/8.14.6?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@react-three%2ffiber/8.14.6?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@react-three%2ffiber/8.14.5/8.14.6?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@react-three%2ffiber/8.14.5/8.14.6?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>pmndrs/react-three-fiber (@&#8203;react-three/fiber)</summary>

###
[`v8.14.6`](https://togithub.com/pmndrs/react-three-fiber/releases/tag/v8.14.6)

[Compare
Source](https://togithub.com/pmndrs/react-three-fiber/compare/v8.14.5...v8.14.6)

#### What's Changed

- fix(native): revert usage of networking stack by
[@&#8203;CodyJasonBennett](https://togithub.com/CodyJasonBennett) in
[pmndrs/react-three-fiber#3042

**Full Changelog**:
pmndrs/react-three-fiber@v8.14.5...v8.14.6

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/ziyadedher/ziyadedher).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xOS4yIiwidXBkYXRlZEluVmVyIjoiMzcuMTkuMiIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant