Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration: please emit ES6 output #51

Closed
jrieken opened this issue Feb 14, 2019 · 1 comment
Closed

Migration: please emit ES6 output #51

jrieken opened this issue Feb 14, 2019 · 1 comment

Comments

@jrieken
Copy link

jrieken commented Feb 14, 2019

We have identified this extension as emitting ES5-JavaScript code and extending API-types, like vscode.Disposable or vscode.CompletionItem. VS Code itself has changed to emit ES6 JavaScript code and too enable functions extending from classes we have added a utility in our code. Given the small number of es5-emitting extensions that also extend API-types we ask for your help, which is emitting ES6 instead of ES5.

For this extension the following should be enough

  • in tsconfig.json change the target to es6
  • recompile via tsc -p tsconfig.json
  • run vsce publish patch

Thanks and #HappyCoding!

@pmneo
Copy link
Owner

pmneo commented Apr 10, 2019

Done with 2.0.1

@pmneo pmneo closed this as completed Apr 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants