Use MPIX_RMA_abs routines to avoid dest disp translation #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
Set --enable-mpix-rma-abs=auto to enable this optimization. If MPIX_Put|Get_abs are not found at configure time, fallback to original version. Note that for now we support only MPIX_Put_abs and MPIX_Get_abs in contiguous put/get. When abs is enabled, the info "rma_abs" is set to both symm windows with the assumption that only put/get will be used. As next step, we should provide the abs version for all RMA/AMO. Info "rma_abs" allows the window to adjust the internal base address to eliminate extra displacement translation for network that requires relative offset (e.g., ofi/psm2). FIXME: if the base address of heap and global data on all processes is not symmetric, directly using local dest in put/get is wrong! We should enable it only when it is symmetric, or store base offsets as fallback. ** later commit will refactor and fix this code. Do not merge before that commit!
10 tasks
|
Close the PR. Because we discussed that the code might become too complex to maintain while the performance benefit is minor. May revisit in future. |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remaining work for this PR:
Note: a later commit for dynamic window will largely refactor the code. The above bug will also be addressed. Do not merge before that commit!