Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the gdbm subproject build on GCC 10 #152

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

64kramsystem
Copy link
Contributor

Make the gdbm subproject build on GCC 10

Two variables were not declared as extern. This works until GCC 9, due to the common model, but his has been disabled on GCC 10, which therefore requires changes. See https://bugs.gentoo.org/705898.

This is a patch of a vendored library (gdbm). Possibly, the formal solution is to upgrade to a more recent version, however, until that's done, compiling on GCC 10 is something that needs to be handled.

A potential solution is to pass -fcommon as CFLAGS down to the makefiles, but I don't know how to do that and if that's possible.

Closes #145.

Two variables were not declared as extern. This works until GCC 9, due to the common model, but his has been disabled on GCC 10, which therefore requires changes.

See https://bugs.gentoo.org/705898.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Does not work on Ubuntu 20.10, with ruby 2.7.1p83
1 participant